HYPERFLEET-1132 - feat: enable parallel E2E execution via Ginkgo#150
Open
kuudori wants to merge 1 commit into
Open
HYPERFLEET-1132 - feat: enable parallel E2E execution via Ginkgo#150kuudori wants to merge 1 commit into
kuudori wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
🚧 Files skipped from review as they are similar to previous changes (6)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe E2E workflow now uses a pinned Ginkgo CLI and compiled test binary, with configurable multi-process execution through Sequence Diagram(s)sequenceDiagram
participant CI
participant Ginkgo
participant E2EProcesses
participant Cleanup
CI->>Ginkgo: invoke E2E suite with --procs
Ginkgo->>E2EProcesses: distribute specs across processes
E2EProcesses->>Cleanup: perform per-process Pub/Sub cleanup
E2EProcesses->>Cleanup: process 1 performs Kubernetes and Helm cleanup
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 7❌ Failed checks (1 warning, 6 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Warning Review ran into problems🔥 ProblemsRepository analysis: Couldn't refresh Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pkg/helper/cleanup.go`:
- Around line 78-95: Update CleanupPubSubResources to construct its helper
through a Pub/Sub-specific constructor that does not create Kubernetes or
dynamic clients. Add NewPubSubCleanupHelper alongside NewCleanupHelper,
initializing only cfg and adapterDeploymentList with the same validation, then
use it for SweepPubsubTestAdapterResources so Kubernetes client failures cannot
block Pub/Sub cleanup.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: f49c0414-fb75-48f5-9888-4d902a547296
📒 Files selected for processing (20)
docs/development.mde2e/adapter/adapter_failover.goe2e/adapter/adapter_with_maestro.goe2e/adapter/maestro_unavailability.goe2e/cluster/adapter_failure.goe2e/cluster/crash_recovery.goe2e/cluster/delete_edge_cases.goe2e/cluster/force_delete.goe2e/cluster/perf_cascade_delete_latency.goe2e/cluster/perf_create_latency.goe2e/cluster/perf_delete_latency.goe2e/cluster/perf_list_filtered_latency.goe2e/cluster/perf_list_latency.goe2e/cluster/perf_read_entity_size_latency.goe2e/cluster/perf_update_latency.goe2e/cluster/stuck_deletion.goe2e/nodepool/perf_create_latency.goe2e/nodepool/perf_delete_latency.gopkg/e2e/suite.gopkg/helper/cleanup.go
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
openshift-hyperfleet/architecture(manual)openshift-hyperfleet/hyperfleet-api(manual)openshift-hyperfleet/hyperfleet-sentinel(manual)openshift-hyperfleet/hyperfleet-adapter(manual)openshift-hyperfleet/hyperfleet-broker(manual)
kuudori
marked this pull request as draft
July 18, 2026 00:18
kuudori
force-pushed
the
parallel-e2e-phase0-view
branch
3 times, most recently
from
July 21, 2026 14:04
008183f to
49a425e
Compare
kuudori
changed the title
- Add ginkgo CLI binary (v2.27.2) via .bingo tooling - Add e2e_suite_test.go entry point for ginkgo --procs=N - Add e2e-ginkgo Makefile target with PROCS= support - Build ginkgo CLI and e2e.test binary in Dockerfile - Add ginkgo.Serial to 5 infrastructure-modifying tests - Convert nodepool creation to Ordered+BeforeAll for isolation - Split AfterSuite into SynchronizedAfterSuite for multi-process safety - Split CleanupResources into per-process and process-1-only phases - Add parallel safety documentation
kuudori
force-pushed
the
parallel-e2e-phase0-view
branch
from
July 21, 2026 15:37
49a425e to
8756517
Compare
kuudori
marked this pull request as ready for review
July 21, 2026 15:38
Contributor
Author
|
@coderabbitai review |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0 preparation for Ginkgo parallel E2E execution (--procs=N). All changes are inert at 1 process - no behavioral change.
Suite hooks:
Serial labels added to specs that are unsafe under concurrency:
Documentation:
Summary
Test Plan
make test-allpassesmake lintpassesmake test-helm(if applicable)